Skip to content

[Bookings] Apply customer data to header #16226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2025
Merged

[Bookings] Apply customer data to header #16226

merged 5 commits into from
Oct 9, 2025
+148 −47

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Oct 8, 2025 •
edited
Loading

Part of: WOOMOB-1426

Description

This is a continuation PR for the [Bookings] Customer data for Booking Details. Applies Customer data to Booking Details header.

Testing steps

  • Use a testing CIAB site with bookings
  • Navigate to Bookings tab
  • Locate a booking that contains a customer with non-empty readable first name / last name.
  • Select the booking and navigate to details view.
  • Make sure the correct customer name and last name is displayed in header section among with service name.
  • Locate a booking that doesn't have a customer / Or simulate this condition by setting customerID to 0 in bookings - response by using Proxyman.
  • Select the booking and navigate to details view.
  • Make sure the header doesn't contain the customer name/last name.

Testing information

Tested on iOS 26 iPhone 17 and iPad simulators.

Screenshots

Снимок экрана 2025-10-08 в 17 39 43
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.5 milestone Oct 8, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Oct 8, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 8, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16226-c5573ee
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commitc5573ee
Installation URL6cqnqbqva25p8
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@RafaelKayumov RafaelKayumov marked this pull request as ready for review October 8, 2025 14:43
@itsmeichigo itsmeichigo self-assigned this Oct 9, 2025
itsmeichigo
itsmeichigo approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

WooCommerce/Classes/ViewModels/Booking Details/HeaderContent.swift Outdated
Comment on lines 2 to 3
import struct Networking.Booking
import struct Networking.Customer
Copy link
Contributor

@itsmeichigo itsmeichigo Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Similar comment as in the previous PR about importing Networking models. Yosemite is the preferred module to import models from.

Copy link
Contributor Author

@RafaelKayumov RafaelKayumov Oct 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in c5573ee

Base automatically changed from WOOMOB-1426-load-and-apply-cusromer-data to trunk October 9, 2025 13:00
@RafaelKayumov RafaelKayumov merged commit b7e0f4f into trunk Oct 9, 2025
14 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1426-apply-customer-data-to-header branch October 9, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

Assignees

@itsmeichigo itsmeichigo

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.5

Development

Successfully merging this pull request may close these issues.

4 participants

@RafaelKayumov @wpmobilebot @itsmeichigo